Dedicated Budgets page (dimension-generic)#140
Open
etiennechabert wants to merge 1 commit into
Open
Conversation
2257d7f to
f1f1a98
Compare
f1f1a98 to
c282b23
Compare
c282b23 to
3971cae
Compare
3971cae to
74bb8cf
Compare
Track annual spend per entity for any dimension (team, account, product, tag). Each budget is prorated against the active date range; cards show spent / prorated / over-budget at a glance. - Pure proration in @costgoblin/core (computeBudgetProgress) is the single source of truth; UI and any future server consumer share it. - One queryCosts per dimension covers every budget on the page (no N+1). - Searchable single-select entity picker for "Add Budget" — extracted from Explorer's inline ValuesPicker into a shared component used by both. - IPC surface is CRUD-only (budgets:get / save / delete); progress computation lives in the renderer. - Save/delete errors surface inline in the editor modal.
74bb8cf to
c0e020c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryCostscall per dimension instead of per-budgetChanges
packages/ui/src/views/budgets.tsx— Budgets page viewbudget-card.tsx— redesigned as compact clickable card with entity name, color-coded progress barbudget-editor-modal.tsx— entity dropdown for create mode, delete button for edit modeApp.tsx— registered Budgets as nav pageentity-detail.tsx,entity-detail.test.tsx, Entity Detail E2E tests