Optimise estimateTransactionFee#3
Open
steshaw wants to merge 12 commits into
Open
Conversation
added 12 commits
December 19, 2022 21:02
From plutus-app -> plutus-ledger -> Ledger.Fee. Copied as-it in here. To be modified shortly.
This adds the ability to check CI result locally.
From from cardano-nodes's cardano-api. Only slightly modified currently (imports).
We are specialised for BabbageEra now, so not needed. These were always zero anyhow.
No longer required since we are specialised to ShelleyBasedEraBabbage.
Currently unused.
This uses the new mcePParams field of MockChainEnv.
Along with evaluateTransactionFee
steshaw
changed the title
steshaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes one call to
toLedgerPParams, but there is at least one more to eliminate when estimating fees. More at DJED-472.Be cautious in merging this change as it:
toLedgerPParamswhen estimating fees. There seems to be at least one more call.toLedgerPParamscoming from our test suite by using a simple trace incardano-apidirectly.djed-test.cabal.projectofstablecoin-plutusshould be updated to point back toetiennejf/plutus-libsfromsteshaw/plutus-libs.cardano-apidirectly and makes an 80% improvement to the execution time ofdjed-test.