fix: resolve cyclic dependency between network and route table#309
Merged
ionos-landgraf-vin merged 2 commits intoJun 22, 2026
Merged
Conversation
Remove routeTableRef from NetworkSpec and NetworkStatus — a network cannot reference a route table that is itself scoped under that network. Make routeTableRef required in SubnetSpec so each subnet explicitly declares its routing configuration rather than relying on an implicit network-level fallback that no longer exists.
aru-amedeo
approved these changes
Jun 18, 2026
| @@ -68,17 +67,9 @@ components: | |||
| x-oapi-codegen-extra-tags: | |||
Contributor
Author
There was a problem hiding this comment.
we should add to the rt description, that the network related routes are "there by default", that is why the rt is part of the network
| zone: "a" | ||
| routeTableRef: | ||
| resource: "route-tables/route-table-1" | ||
| skuRef: |
Contributor
Author
There was a problem hiding this comment.
should also be reflected in the usecase.md etc.
- Add note to NetworkSpec description that network-local routes are present by default in associated route tables - Update usage.md: move routeTableRef from network to subnet example - Fix rbac.yaml scopes example (minItems violation from PR #306) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jannotti-glaucio
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove routeTableRef from NetworkSpec and NetworkStatus — a network cannot reference a route table that is itself scoped under that network.
Make routeTableRef required in SubnetSpec so each subnet explicitly declares its routing configuration rather than relying on an implicit network-level fallback that no longer exists.