feat: add Ember adapter package and E2E test app#32
Open
eugenioenko wants to merge 2 commits into
Open
Conversation
Implements the Ember.js adapter (oidc-js-ember) with: - OidcService: standalone service wrapping OidcClient with reactive state - createOidcService: factory for creating Ember DI-compatible services with @Tracked - authenticatedRoute: route protection helper for beforeModel hooks - subscribe method for non-Ember reactive updates - Full TSDoc comments on all exports Adds E2E test app at tests/e2e/ember-app/ with all required data-testid attributes matching the shared Playwright spec contract. Includes playwright.ember.config.ts and test:ember script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
eugenioenko
force-pushed
the
feat/ember-adapter
branch
from
54c9df4 to
690dd25
Compare
- Exclude ember-app and docs-web/.astro from eslint (CJS/generated files) - Allow _-prefixed unused vars (standard convention for intentionally unused params) - Remove unused imports in Vue, Lit, and Ember adapter types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/ember/(oidc-js-ember) with service + factory patternOidcService,createOidcService()factory,authenticatedRoute()helpertests/e2e/ember-app/with full data-testid contractTest plan
pnpm --filter oidc-js-ember buildpassespnpm --filter e2e-tests test:emberpasses🤖 Generated with Claude Code