fix: logout redirect races with RequireAuth login redirect#76
Merged
Conversation
Previously, logout() cleared auth state (isAuthenticated: false) before redirecting to the end_session_endpoint. This triggered RequireAuth to call login(), which raced with and won over the logout redirect. Now logout redirects first and returns immediately — state is only cleared locally when no end_session_endpoint is available. Also removes the Kasper adapter's unsubscribe-before-logout workaround since the race is fixed in the client itself. Closes #71 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…avior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logout()to redirect toend_session_endpointbefore clearing auth state, preventingRequireAuthfrom triggering a competinglogin()redirectend_session_endpointis availableunsubscribe-before-logoutworkaround since the race is now fixed in the clientTest plan
Closes #71
🤖 Generated with Claude Code