fix(canvas): clone-based selection highlights#60
Merged
Conversation
…tating shapes Replace the stroke-mutation highlight system with clone-based overlays in the highlights group. The original shape is never modified, fixing issues where properties panel, undo/delete, copy/paste, and property edits would capture or restore the highlight color instead of the real values. Highlight clones scale with zoom to stay visually consistent. Fixes #45, #47, #50, #52 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
highlightsgroup — original shapes are never modifiedgetOriginal*/setOriginal*indirection2 / zui.scale) to stay visually consistent, matching existing resize handle behaviorTest plan
pnpm buildpassespnpm lintpasses (0 errors)npx playwright test e2e/selection-highlight.spec.ts)Fixes #45, #47, #50, #52
🤖 Generated with Claude Code