fix: isolate label loading by chain - #725
Conversation
Track in-flight label fetches per chain and gate publication on the latest active load. Cover chain switches, fetch reuse, force refreshes, and stale wrap-pair probes.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🚅 Deployed to the euler-lite-pr-725 environment in euler-lite
|
LeonardEulerXYZ
left a comment
There was a problem hiding this comment.
No blocking findings at 4b4712052630f9762b9c2a5b817938909ee86abb.
The per-chain in-flight map and latest-load generation guard keep products/entities/vault-label publication coherent across A→B and A→B→A switches. The identity-checked cleanup preserves a force-refresh replacement, and the additional chain/load/probe checks prevent stale wrap-pair writeback. The map remains bounded by the configured chain set and settled entries are removed.
Validation performed:
npm run test:run -- tests/composables/useEulerLabels.test.ts tests/composables/useEulerAccount.test.ts tests/composables/useVaults.test.ts tests/composables/useGeoBlock-wrap-pair.test.ts tests/utils/euler-labels-utils.test.ts tests/composables/useEulerOracleAdapters.test.ts(44 tests passed)npm run typechecknpx eslint composables/useEulerLabels.ts tests/composables/useEulerLabels.test.tsgit diff --check origin/development...HEAD
I did not run browser/API smoke: the changed behavior is deterministic in-flight ordering and stale-publication suppression, which the deferred unit tests exercise directly; the live labels proxy cannot reliably reproduce those races.
Summary
Changes
Test plan
Residual