Skip to content

chore: migrate off deprecated perspective APIs (SDK 2.0 / euler-sdks#93) - #800

Closed
kasperpawlowski wants to merge 1 commit into
developmentfrom
feature/lite-324-migrate-off-deprecated-perspective-apis
Closed

kasperpawlowski wants to merge 1 commit into
developmentfrom
feature/lite-324-migrate-off-deprecated-perspective-apis

Conversation

@kasperpawlowski

Copy link
Copy Markdown
Contributor

Summary

Prepares euler-lite for the SDK release containing euler-xyz/euler-sdks#93 (LITE-324). Draft — do not merge until that release publishes and the version-bump commit is added. CI typecheck will fail on this PR until then: the renamed APIs don't exist in the pinned 1.2.5.

Changes

Method renames (behavior identical — the ESCROW enum member survives; #93 only retires GOVERNED/EDGE):

  • server/utils/labels-view.ts, server/utils/vaults-cache.ts, utils/vault/categories.ts — the three real escrow-discovery call sites: fetchVerifiedVaultAddressesfetchPerspectiveVaultAddresses
  • utils/sdk-vault-meta-stub.tsIVaultMetaService throw-stubs renamed to match the new interface
  • Test mocks in tests/server/vaults-cache.test.ts and tests/composables/useVaults.test.ts

Dead mapping removal#93 also deletes these from the SDK deployment types; lite mapped them into its address objects but nothing consumed them (verified by repo-wide trace):

  • Perspective addresses: eulerEarnGovernedPerspective, eulerUngoverned0xPerspective, eulerUngovernedNzxPerspective, governedPerspective
  • Non-perspective fields removed by the same PR: eUSD, seUSD (incl. lite's EulerTokenAddresses type), externalVaultRegistry, irmRegistry, oracleAdapterRegistry

Conceptually lite is already aligned with #93's rationale: trust comes from euler-labels + governor verification, and lite only uses the structural ESCROW perspective.

Verification

Validated against an SDK built locally from the #93 branch head (installed as a tarball, not committed):

  • nuxt typecheck clean
  • Full suite: 1612 passed, 1 skipped
  • Lint clean
  • After the SDK release: add the package.json/lockfile bump commit, re-run CI (note .npmrc min-release-age=7 — install the fresh version from outside the repo or wait out the window)

Merge dependency

Blocked on euler-xyz/euler-sdks#93 publishing (planned as the 2.0.0 breaking release, separate from the additive 1.3.0 carrying safeAccountService from euler-xyz/euler-sdks#94).

Tracks euler-sdks#93: fetchVerifiedVaultAddresses/fetchVerifiedVaults rename to fetchPerspectiveVaultAddresses/fetchPerspectiveVaults (escrow discovery call sites in the server caches, labels view, vault categories, and the registry meta-stub), and the deployment-type fields removed there (perspective addresses plus eUSD/seUSD/externalVaultRegistry/irmRegistry/oracleAdapterRegistry) drop out of the address mappings — all were mapped but consumed nowhere. No behavior change: lite only uses the structural ESCROW perspective, which survives the rename.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aa23dad0-24f3-47b0-9f59-64bcffcdc1c0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@railway-app

railway-app Bot commented Aug 11, 2026

Copy link
Copy Markdown

🚅 Deployed to the euler-lite-pr-800 environment in euler-lite(dev,PR previews)

Service Status Web Updated (UTC)
dev-build ✅ Success (View Logs) Web Aug 11, 2026 at 10:27 am

@railway-app
railway-app Bot temporarily deployed to euler-lite(dev,PR previews) / euler-lite-pr-800 August 11, 2026 10:26 Destroyed
@kasperpawlowski

Copy link
Copy Markdown
Contributor Author

Closing — after euler-xyz/euler-sdks#93 dropped the fetchPerspectiveVault* rename (the perspectives' own on-chain API is isVerified()/verifiedArray(), so the SDK keeps the fetchVerifiedVault* names), nothing in this PR remains:

Master only references the surviving SDK surface — three fetchVerifiedVaultAddresses(chainId, [StandardEVaultPerspectives.ESCROW]) call sites and no removed enum members or Deployment keys — so euler-lite is already compatible with the upcoming breaking SDK release as-is. The only remaining action is the routine package.json/lockfile bump once it publishes, which fits a fresh one-commit PR at that point (mind .npmrc min-release-age=7). Reopen if you'd rather keep this as the bump placeholder.

@kasperpawlowski

kasperpawlowski commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Correction of the earlier status note: the rename portion of euler-xyz/euler-sdks#93 was deliberately reverted before merge — published 2.0.0 matches the SDK's main and fetchVerifiedVault* remain the stable surface. No future rename release is pending, so this PR is correctly closed: its deployment-field cleanup landed via the stack's 2.0.0 bump, and its renames are not needed.

@kasperpawlowski
kasperpawlowski deleted the feature/lite-324-migrate-off-deprecated-perspective-apis branch August 11, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant