docs: address screening, oracle adapter display, and reward eligibility - #862
Merged
Seranged merged 1 commit intoSep 14, 2026
Merged
Conversation
Add runbooks for connect-time wallet screening (VPN as audit metadata, no reviewed-execution re-screen) and the shared Oracles/Explore adapter display contract after V3 assessments. Document provider-owned reward eligibility notices on projected yield, and correct the stale claim that preparation rechecks the wallet with a VPN verdict.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
🚅 Deployed to the euler-lite-pr-862 environment in euler-lite(dev,PR previews)
|
railway-app
Bot
temporarily deployed
to
euler-lite(dev,PR previews) / euler-lite-pr-862
September 11, 2026 07:34
Destroyed
Seranged
self-requested a review
September 14, 2026 10:13
Seranged
marked this pull request as ready for review
September 14, 2026 10:13
Seranged
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only. Captures three recently changed subsystems that shipped without a matching developer runbook, and corrects one stale claim in transaction-building.
Docs added
docs/address-screening.md— connect-time wallet screening after PR fix: keep VPN usage as audit metadata #861 (VPN as audit metadata): wagmi gate, fail-closed data-v3 proxy,chain: "all"upstream coverage, VPN merge rules, first-party CORS exception, no-store cache, and why reviewed execution does not re-screen.docs/oracle-adapter-display.md— shared Oracles-block / Explore-matrix contract after V3 assessments (feat: migrate oracle checks to v3 #842): label vs Route, never trust on-chainname(), recognized/unrecognized/unassessed, active-route catalogue vs per-address fallback, EVC-simulated quotes, empty-router-set null policy.Docs updated
docs/transaction-building.md— removes the stale claim that reviewed execution rechecks the wallet with a VPN verdict.docs/projected-yield.md— provider-owned reward eligibility notices (none/complete/incomplete) from feat: link reward eligibility requirements #837 / fix: honor projected reward after-state metadata #850.docs/architecture.md,docs/development-guide.md,docs/geo-blocking.md,docs/vault-labels-and-verification.md,docs/pricing-system.md,docs/pyth-oracle-handling.md,docs/README.md— cross-links and the screening/V3 proxy inventory.Codepaths covered
composables/useAddressScreen.ts,composables/useWagmi.ts,services/screening.ts,services/vpn.ts,server/api/internal/screen-address.post.ts,server/utils/screening.ts,server/middleware/cors.ts,features/reviewed-execution/policy/engine.ts.utils/oracle-adapter-views.ts,entities/oracle.ts,composables/useEulerOracleAdapters.ts,composables/useEulerOracleRouters.ts,composables/useOracleAdapterPrices.ts,VaultOverviewBlockOracleAdapters.vue,DiscoveryMarketMatrix.vue.entities/reward-campaign.ts,utils/projected-yield.tsmergeProjectedRewardCampaigns,RewardEligibilityNotice.vue.Knowledge gaps addressed
development. Source has moved since then (VPN telemetry-only; V3 assessments via SDK, not/api/internal/oracle-adapters).transaction-building.mdstill said preparation re-screens with VPN; tests assertscreenAddress/detectVpnare not called.Verified against source plus 173 targeted vitest cases (12 files).
Test plan
npx vitest runon the 12 related test files (173 passed)