Skip to content

docs: address screening, oracle adapter display, and reward eligibility - #862

Merged
Seranged merged 1 commit into
developmentfrom
cursor/engineering-documentation-updates-c46c
Sep 14, 2026
Merged

Seranged merged 1 commit into
developmentfrom
cursor/engineering-documentation-updates-c46c

Conversation

@cursor

@cursor cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

Summary

Docs-only. Captures three recently changed subsystems that shipped without a matching developer runbook, and corrects one stale claim in transaction-building.

Docs added

  • docs/address-screening.md — connect-time wallet screening after PR fix: keep VPN usage as audit metadata #861 (VPN as audit metadata): wagmi gate, fail-closed data-v3 proxy, chain: "all" upstream coverage, VPN merge rules, first-party CORS exception, no-store cache, and why reviewed execution does not re-screen.
  • docs/oracle-adapter-display.md — shared Oracles-block / Explore-matrix contract after V3 assessments (feat: migrate oracle checks to v3 #842): label vs Route, never trust on-chain name(), recognized/unrecognized/unassessed, active-route catalogue vs per-address fallback, EVC-simulated quotes, empty-router-set null policy.

Docs updated

  • docs/transaction-building.md — removes the stale claim that reviewed execution rechecks the wallet with a VPN verdict.
  • docs/projected-yield.md — provider-owned reward eligibility notices (none / complete / incomplete) from feat: link reward eligibility requirements #837 / fix: honor projected reward after-state metadata #850.
  • docs/architecture.md, docs/development-guide.md, docs/geo-blocking.md, docs/vault-labels-and-verification.md, docs/pricing-system.md, docs/pyth-oracle-handling.md, docs/README.md — cross-links and the screening/V3 proxy inventory.

Codepaths covered

  • Screening: composables/useAddressScreen.ts, composables/useWagmi.ts, services/screening.ts, services/vpn.ts, server/api/internal/screen-address.post.ts, server/utils/screening.ts, server/middleware/cors.ts, features/reviewed-execution/policy/engine.ts.
  • Oracle display: utils/oracle-adapter-views.ts, entities/oracle.ts, composables/useEulerOracleAdapters.ts, composables/useEulerOracleRouters.ts, composables/useOracleAdapterPrices.ts, VaultOverviewBlockOracleAdapters.vue, DiscoveryMarketMatrix.vue.
  • Eligibility: entities/reward-campaign.ts, utils/projected-yield.ts mergeProjectedRewardCampaigns, RewardEligibilityNotice.vue.

Knowledge gaps addressed

  1. Closed unmerged PR docs: address screening runbook and oracle adapter display #835 left screening and oracle-display runbooks off development. Source has moved since then (VPN telemetry-only; V3 assessments via SDK, not /api/internal/oracle-adapters).
  2. transaction-building.md still said preparation re-screens with VPN; tests assert screenAddress / detectVpn are not called.
  3. Reward eligibility notices (feat: link reward eligibility requirements #837/fix: honor projected reward after-state metadata #850) had no owner doc in projected yield.

Verified against source plus 173 targeted vitest cases (12 files).

Test plan

  • Source-check docs against the listed files
  • npx vitest run on the 12 related test files (173 passed)
Open in Web View Automation 

Add runbooks for connect-time wallet screening (VPN as audit metadata,
no reviewed-execution re-screen) and the shared Oracles/Explore adapter
display contract after V3 assessments. Document provider-owned reward
eligibility notices on projected yield, and correct the stale claim that
preparation rechecks the wallet with a VPN verdict.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3784b5dd-bd37-4514-a7b3-aaed78a130fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@railway-app

railway-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

🚅 Deployed to the euler-lite-pr-862 environment in euler-lite(dev,PR previews)

Service Status Web Updated
dev-build ✅ Success (View Logs) Web Sep 11, 2026 at 7:36 am UTC

@railway-app
railway-app Bot temporarily deployed to euler-lite(dev,PR previews) / euler-lite-pr-862 September 11, 2026 07:34 Destroyed
@Seranged
Seranged self-requested a review September 14, 2026 10:13
@Seranged
Seranged marked this pull request as ready for review September 14, 2026 10:13
@Seranged
Seranged merged commit 2590447 into development Sep 14, 2026
6 checks passed
@Seranged
Seranged deleted the cursor/engineering-documentation-updates-c46c branch September 14, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants