feat: validate reciprocal cross-account repayments - #101
Conversation
Verify exact-vault share repayments from opposite accounts merge into one EVC batch without withdraw, skim, or collateral cleanup calls.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe pull request adds a regression test for reciprocal same-vault repayments. The test verifies merged ChangesRepayment merge regression
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds coverage for merged reciprocal exact-vault repayments, ensuring each repayment and controller disable call remains correctly ordered without extra withdrawal or cleanup operations. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
planRepayFromDepositprimitive already carries the required source-account and debt-receiver separation.Changes
repayWithShares, controller disable,repayWithShares, controller disable.maxUint256amount.Safety properties
Test plan
Summary by CodeRabbit