Skip to content

fix: accept oracle router activity events - #86

Merged
Seranged merged 1 commit into
mainfrom
feat/activity-oracle-router-events
Aug 7, 2026
Merged

Seranged merged 1 commit into
mainfrom
feat/activity-oracle-router-events

Conversation

@Seranged

@Seranged Seranged commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Accept EulerRouter governance events returned by the V3 Activity API.
  • Keep strict response validation while preventing supported router events from invalidating an Activity page.

Changes

  • Add oracle configuration, fallback oracle, resolved vault, and oracle governor events to the normalized Activity contract.
  • Cover all four event types with normalization regression tests.

Test plan

  • Run the Activity service test suite.
  • Run the SDK typecheck.
  • Run SDK lint.
  • Build the SDK and consume the result from Lite locally.

Summary by CodeRabbit

  • New Features

    • Added support for additional EulerRouter governance activity events, including oracle configuration, fallback oracle, resolved vault, and oracle governor updates.
  • Tests

    • Added coverage confirming these governance events are recognized and normalized correctly.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6978c09-69e4-4fbc-bf60-e84a2d574482

📥 Commits

Reviewing files that changed from the base of the PR and between 1430b56 and d3b11a2.

📒 Files selected for processing (2)
  • packages/euler-v2-sdk/src/services/activityService/activityServiceTypes.ts
  • packages/euler-v2-sdk/test/activityService.test.ts

📝 Walkthrough

Walkthrough

The activity service adds four EulerRouter governance event types. Tests verify that V3 normalization accepts each event and that each event appears in ACTIVITY_EVENT_TYPES.

Changes

Oracle governance activity events

Layer / File(s) Summary
Add and validate oracle event types
packages/euler-v2-sdk/src/services/activityService/activityServiceTypes.ts, packages/euler-v2-sdk/test/activityService.test.ts
The activity event list adds four oracle-related values. Tests verify governance normalization and event-list membership for each value.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: support for oracle router activity events.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/activity-oracle-router-events

Comment @coderabbitai help to get the list of available commands.

@Seranged
Seranged merged commit 1a4d6f9 into main Aug 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants