Adopt the profiled repository contract - #1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adopts the “profiled repository contract” for the Skillfoundry agent hub by adding an explicit repository declaration, a universal make check gate, updated architecture/front-door documentation, and least-privilege CI + Dependabot to keep GitHub Actions pins current.
Changes:
- Add
repo.tomlrepository contract declaration (shape, lifecycle, risk, artifacts, workspaces). - Introduce a universal
Makefileinterface (make check/test/operator-check) and document how to validate in CI vs operator hosts. - Pin GitHub Actions by SHA in CI and add Dependabot updates for Actions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
repo.toml |
Declares repository contract metadata (schema, shape, lifecycle, artifacts, workspaces). |
README.md |
Adds lifecycle/verification notes and points contributors to make check and architecture docs. |
Makefile |
Provides the canonical “make check” gate, unit tests entrypoint, and operator-only mount verification. |
docs/architecture.md |
Documents authority boundaries, mount expectations, and the current transition exception framing. |
.github/workflows/validate-context.yml |
Pins CI actions, applies least-privilege permissions, and runs the canonical make check gate. |
.github/dependabot.yml |
Enables monthly Dependabot updates for GitHub Actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'make operator-check Also require live context mounts (host only)' | ||
|
|
||
| check: | ||
| @python3 -c 'import pathlib,tomllib; r=pathlib.Path("."); d=tomllib.loads((r/"repo.toml").read_text()); assert d["schema_version"] == 1 and d["shape"] == "control-plane"; [(_ for _ in ()).throw(AssertionError(f"missing {p}")) for p in ("README.md","repo.toml","Makefile","AGENTS.md","CLAUDE.md","docs/architecture.md") if not (r/p).exists()]' |
| @python3 -c 'import pathlib,tomllib; r=pathlib.Path("."); d=tomllib.loads((r/"repo.toml").read_text()); assert d["schema_version"] == 1 and d["shape"] == "control-plane"; [(_ for _ in ()).throw(AssertionError(f"missing {p}")) for p in ("README.md","repo.toml","Makefile","AGENTS.md","CLAUDE.md","docs/architecture.md") if not (r/p).exists()]' | ||
| python3 scripts/check_workspace.py | ||
| python3 -m unittest discover -s tests | ||
| git diff --check |
| filesystem/network isolation, or brokered task credentials. The supervisor | ||
| owns that bounded host-wide gap under ADR-0050. Prompt/instruction baselines | ||
| for the existing agent declarations also remain to be established under | ||
| ADR-0039; until then the central inventory must keep this repo `migrating`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ADR-0050 repository declaration, universal make check interface, architecture/front-door documentation, pinned least-privilege CI, and Dependabot configuration. Shape-specific checks preserve existing domain boundaries. Dated exceptions remain explicit, so this does not claim full conformance before prompt-eval, typing, runtime-path, dependency-lock, or host-containment gaps close.