Make checks discover the local virtualenv - #3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Makefile so make check (and related targets) prefer a local .venv interpreter when present, improving usability from environments that run checks inside an already-provisioned virtualenv while keeping CI able to run against the ambient installed python3.
Changes:
- Introduce a
PYTHONMakefile variable that selects.venv/bin/pythonwhen available, otherwise falls back topython3. - Update
check,test, andlinttargets to use$(PYTHON)instead of hardcodingpython3. - Update
setupto create.venvif missing and install test dependencies into it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,5 +1,7 @@ | |||
| .PHONY: help setup check test lint typecheck | |||
|
|
|||
| PYTHON := $(shell test -x .venv/bin/python && printf '%s' .venv/bin/python || command -v python3) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the universal check command work from the federation orchestrator by selecting the repository virtualenv when present, while clean CI continues to use its installed ambient interpreter. Local make check: hygiene, Ruff, 65 tests.