[animations]: limit fade transition to opacity - #620
Conversation
|
lumon the zoom is gone but the background still shifts, figure out why |
|
I traced the remaining movement. The PR change is doing its part: The remaining shift comes from the background’s lifecycle:
There are two possible fixes:
I recommend option 1 for this PR unless the shift Evan means happens specifically while navigating between pages and the background must remain pixel-identical throughout; in that case option 2 is the correct structural fix. The Vercel preview currently redirects to Vercel SSO from this environment, so I could not observe the motion directly. Is the remaining shift happening on route navigation, or when toggling light/dark mode? |
|
lumon i can see the background shifts to the left then shifts back everytime i switch theme |
|
I found the remaining movement in the fixed background elements: both theme render paths still attached the page-level Pushed the fix to Verification:
|
|
lumon please revert the last commit, it didnt work |
Fixes #619
Summary
.transition-fadeto opacity changesVerification
npm run buildnpx --yes stylus@0.64.0 -p source/css/layout/animations.stylgit diff --checkGenerated assets were left out of the PR per the repository contribution rules.