Run test workflow automatically on PRs and pushes to main - #43
Merged
Conversation
The Tests workflow was workflow_dispatch-only, so PRs got no automated lint/test check — merges relied entirely on contributors running pytest and ruff locally. Trigger it on pull_request and push to main (keeping the manual dispatch), add a concurrency group so the runner isn't tied up on stale commits, and move the jobs onto the org's self-hosted Linux x64 runner per the project's runner policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/workflows/tests.ymlwasworkflow_dispatch-only, so opening a PR ran no automated lint/test check. Merges relied entirely on contributors runningpytest/rufflocally (as happened for #35–#42).Fix
pull_request(→ main) andpush(→ main), keepingworkflow_dispatchfor manual runs.concurrencygroup keyed on the ref withcancel-in-progress, so the single self-hosted runner isn't tied up re-testing superseded commits.[self-hosted, Linux, X64]) per the project runner policy, replacingubuntu-latest.Validation
This PR self-validates: the
pull_requesttrigger means the new workflow runs against this very branch. If the checks below go green on the self-hosted runner, the automation works end to end.Follow-up to consider after this lands: add
lintandtestas required status checks in branch protection so they actually gate merges (currently the protection requires a review but no status check).