build: clear Xcode preflight in build-macos.sh - #10
Merged
Conversation
When only the Command Line Tools are selected (active dir /Library/Developer/CommandLineTools), the build previously failed deep in reload.sh with a cryptic 'xcodebuild requires Xcode' xcode-select error. Check up front and print exactly what to do (xcode-select -s, or install Xcode). The guard is a no-op when xcodebuild already works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a laptop with only the Command Line Tools selected,
build-macos.shfailed deep inreload.shwith:This adds an up-front check so the script says exactly what to do instead:
(or, if Xcode isn't installed, an install message). Purely additive — a no-op when
xcodebuildalready works, so it can't affect a working build.