feat: include app.defaultWorkspacePath in generated cmux.json template - #12
Merged
Merged
Conversation
PR #5 added the `app.defaultWorkspacePath` setting everywhere it is consumed (resolver, Settings UI row, JSON-path parsing, schema, docs) but never added it to the commented-out template that cmux writes to ~/.config/cmux/cmux.json on first launch. As a result the setting was absent from a fresh config and undiscoverable by users browsing the file. Add it to the `app` section of defaultTemplateSections() next to the related `workspaceInheritWorkingDirectory` key, sourcing the value from the catalog default ("") so it renders as a commented placeholder: `// "defaultWorkspacePath": "",` Claude-Session: https://claude.ai/code/session_01CNYr3XgjVDLsPNnPQxarn4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
app.defaultWorkspacePath(added in #5) was missing from the commented-out template that cmux writes to~/.config/cmux/cmux.jsonon first launch. The setting worked everywhere it's consumed — resolver, Settings → App row, JSON-path parsing, schema, docs — but never appeared in a fresh config, making it undiscoverable for users browsing the file.This adds it to the
appsection ofdefaultTemplateSections()inSources/KeyboardShortcutSettingsFileStore+Template.swift, beside the relatedworkspaceInheritWorkingDirectorykey. The value comes from the catalog default (""), so it renders as a commented placeholder:// "defaultWorkspacePath": "",Notes
workspaceInheritWorkingDirectoryline (sameDefaultsKey<String>pattern already used throughout this file).cmux.jsonis missing, so existing users won't see the line regenerated — they delete/rename the file and relaunch, or add the key by hand.https://claude.ai/code/session_01CNYr3XgjVDLsPNnPQxarn4