feat: custom notification sound for android#5
Open
rranjan14 wants to merge 8 commits intoevennit:mainfrom
Open
feat: custom notification sound for android#5rranjan14 wants to merge 8 commits intoevennit:mainfrom
rranjan14 wants to merge 8 commits intoevennit:mainfrom
Conversation
Author
|
Hey @kevpug , thanks for this awesome plugin. I have added support for custom sounds in android. Would love to have your inputs on this. |
Contributor
|
Hi @rranjan14! I haven't had the time to test it / integrate it yet. Will do next week! It will be a great addition to the plugin thanks to you :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
addSoundsToFolderhas been added to theplugin/android.tsfile to add sound files to the Android resource folders.addSoundsToFolderfunction checks if theandroidSoundsproperty in the app config is an array of sound files and adds them to therawfolder in the project root.saveSoundfunction is used to save a sound file to therawfolder.plugin/types.tsfile has been updated to include a new propertyandroidSoundsin theNotifeeExpoPluginPropstype.plugin/utils.tsfile has been updated to validate theandroidSoundsproperty in the app config.As mentioned here, to use custom sound for notifications, the local file has to be added to
rawfolder.To see the changes, this plugin needs to be build again.