Add new methods to interface#3
Open
HolgerDoerner wants to merge 2 commits intoevent-engine:masterfrom
Open
Conversation
codeliner
requested changes
Oct 15, 2020
src/EventStore.php
Outdated
| * @param int $limit | ||
| * @return \Iterator | ||
| */ | ||
| public function loadStreamEvents(string $streamName, int $skip, int $limit): \Iterator; |
There was a problem hiding this comment.
skip should default to 0 and limit to null
src/EventStore.php
Outdated
| /** | ||
| * @param string $streamName | ||
| * @param int $skip | ||
| * @param int $limit |
src/EventStore.php
Outdated
| * @param int $limit | ||
| * @return \Iterator | ||
| */ | ||
| public function loadStreamEventsReverse(string $streamName, int $skip, int $limit): \Iterator; |
There was a problem hiding this comment.
skip should default to 0 and limit to null
src/EventStore.php
Outdated
| /** | ||
| * @param string $streamName | ||
| * @param int $skip | ||
| * @param int $limit |
|
pagination should be optional. By default the returned cursor should iterate over all events in the stream. See my inline comments for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the methods
loadStreamEventsandloadStreamEventsReverseto theEventStoreinterface.I did this as part of Hacktoberfest, so I would appreciate it if You would label the Issue accordingly 😃
Closes #2