Merged
Conversation
Enable the native EPUB reader on macOS with page-embedded info bars, settings preview, menu command integration, and macOS-specific settings UI. Refactor shared EPUB reader helpers for overlays, color parsing, and WebPub platform support while keeping unsupported actions hidden on macOS. Also restore stable keyboard shortcuts, localize new strings, and keep swipe page turning disabled for now after removing the unstable trackpad implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS EPUB reader had fallen behind the iOS implementation. It exposed unsupported actions, lacked the native settings flow and live preview, and regressed in command handling and top/bottom reader chrome behavior.
Approach
Bring macOS EPUB onto the same native reader path as iOS, then align the surrounding capabilities instead of layering more macOS-only patches. The reader now uses page-embedded info bars, macOS-specific settings UI with live preview, capability-driven menu commands, and shared EPUB support helpers for overlays, colors, and WebPub platform glue.
Scope
Validation