Merged
Conversation
Restore smooth EPUB overlay text transitions after the overlay support refactor changed hidden entries to clear label text before fade-out. Update the shared overlay model to preserve text while hidden, wire macOS overlay transitions for controls-mode switches, and align macOS EPUB keyboard shortcuts with Divina so Space/C toggle the overlay state consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The EPUB reader regressed after the shared overlay refactor. Hidden overlay entries started clearing their label text before fading out, which made iOS transitions feel abrupt, and macOS EPUB no longer exposed the same overlay toggle behavior as Divina.
Approach
Restore the overlay model so hidden entries keep their last rendered text while only visibility changes animate. On macOS, animate controls-mode switches in the shared AppKit overlay and route
Space/Cthrough the EPUB reader's overlay toggle path so keyboard behavior matches Divina.Scope
Validation
make build-macosmake build-ios