feat(bashkit): Phase 12 - Spec test framework for compatibility testing#14
Merged
feat(bashkit): Phase 12 - Spec test framework for compatibility testing#14
Conversation
Implements four major text processing commands: - jq: JSON processor using the jaq library - Field access, array indexing, keys, length - Full jq filter syntax support - grep: Pattern matching using regex crate - Flags: -i (case insensitive), -v (invert), -n (line numbers) - Flags: -c (count), -l (files), -F (fixed string), -E (extended) - sed: Stream editor with substitution support - s/pattern/replacement/[g] substitution - Address ranges (line numbers, $, regex) - Delete (d) and print (p) commands - In-place editing with -i flag - awk: Pattern scanning and processing - Field splitting with -F option - BEGIN/END blocks - Pattern matching (regex and expressions) - Built-in variables: NR, NF, FNR, FS, OFS, ORS - Functions: length, substr, index, split, gsub, sub, toupper, tolower - Arithmetic and string operations - Compound assignment operators (+=, -=, etc.) Also fixes single-quoted string handling: - Added LiteralWord token type for single-quoted strings - Single-quoted strings no longer undergo variable expansion - This fixes $1, $2 etc. being incorrectly expanded in awk/sed programs Test coverage: 177 tests passing https://claude.ai/code/session_01A16cD8ztbTJs2PB2iHe1Ua
Adds a comprehensive spec test framework inspired by just-bash: - Spec test runner with .test.sh file format - 114 bash compatibility test cases - Text processing tests (awk, grep, sed, jq) - Comparison runner against real bash - KNOWN_LIMITATIONS.md documenting gaps - Testing strategy spec (specs/004-testing.md) Current compatibility: 78.3% (83/106 tests passing) https://claude.ai/code/session_01A16cD8ztbTJs2PB2iHe1Ua
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
cargo testpasses (9 passed, 2 ignored)cargo clippycleancargo fmtappliedCurrent compatibility: 78.3% (83/106 tests passing)