Print more than one json in FileLogger#52
Open
pandid wants to merge 2 commits intoeverwatchsolutions:masterfrom
Open
Print more than one json in FileLogger#52pandid wants to merge 2 commits intoeverwatchsolutions:masterfrom
pandid wants to merge 2 commits intoeverwatchsolutions:masterfrom
Conversation
|
This is good. My team will need this functionality as well. Once your PR is accepted by everwatch, I think I'm going to extend it a little bit further by adding the option for timestamp based roll ups as well. |
Member
|
Sorry for the very long delay on reviewing this. This seems like a good idea, but could you make it default not require the new file.lines? i.e. default it to one if it's not set? And then update the README with the new option? Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to extend the functionality of the FileLogger. Originally it writes just one json object in a file and then moves to the next. If one wants to create big number of such objects this approach not feasible. We added "file.lines". The current functionality is handled by setting "file.lines" to 1 or say "file.lines":"1000".
Commits
added functionality to add print more than one json object per file in FileLogger.