-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 매장 설정 페이지 구현 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
handwoong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import 잘못됬어요 확인해주세요!
| ksnetDeviceNo: z | ||
| .string() | ||
| .min(1, "기기 번호를 입력해주세요.") | ||
| .max(10, "기기 번호는 10자 이내로 입력해주세요."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10자가 아닌 20자까지 입력 가능합니다!
| const settingsSchema = z.object({ | ||
| ksnetDeviceNo: z | ||
| .string() | ||
| .min(1, "기기 번호를 입력해주세요.") | ||
| .max(10, "기기 번호는 10자 이내로 입력해주세요."), | ||
| printerLocation: z.enum(["POS", "HALL"]), | ||
| showMenuPopup: z.boolean(), | ||
| showOrderTotalPrice: z.boolean(), | ||
| showOrderMenuImage: z.boolean(), | ||
| countryOfOrigins: z.array(z.object({ | ||
| item: z.string(), | ||
| origin: z.string(), | ||
| })), | ||
| staffCallOptions: z.array(z.string()), | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POS 여분 테이블 표시 개수 설정이 누락되어있습니다
|
|
||
| export interface StoreApplication { | ||
| registrationId: string; | ||
| accountid: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타있어요 accountid -> accountId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 모달은 왜 필요한건가요?
| mode: "onSubmit", | ||
| reValidateMode: "onChange", | ||
| defaultValues: { | ||
| ksnetDeviceNo: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기본값 DPTOTEST03 으로 변경해주세요.
| const handleAddStaffCallOption = () => { | ||
| // TODO: 직원 호출 옵션 추가 로직 | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 함수 위치 폼 useWatch 하단(44번 라인) 으로 옮겨주세요.

📝 작업 내용
📷 스크린샷 (선택)
💬 리뷰 요구사항(선택)