Bye ESI versions, Hello compatibility date#103
Merged
Crypta-Eve merged 4 commits intoeveseat:3.xfrom Oct 9, 2025
Merged
Conversation
ESI no longer requires a endpoint version. /v1/my/endpoint is now equivalent to /my/endpoint. With this commit, eseye no longer sends ESI requests with version numbers. source: https://developers.eveonline.com/blog/changing-versions-v42-was-getting-out-of-hand
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESI no longer uses versions in the endpoint URL, and as of right now, they also have no effect. See https://developers.eveonline.com/blog/changing-versions-v42-was-getting-out-of-hand
This PR removes esi versions while keeping compatibility with existing code. This is done by effectively turning ->setVersion() and ->getVersion() into no-ops. You can still call them, but they do nothing.
At the same time, this PR introduces the
X-Compatibility-Dateheader. You can set it's value using -> setCompatibilityDate(string $date). If no date is set, like with old code, we use the date of this PR so code should stay as compatible as possible.