Open
Conversation
| ->first(); | ||
| $config = $this->normalizeProjectConfiguration($project->configuration); | ||
|
|
||
| // dd($project, $corporation); |
| }) | ||
| ->addColumn('reward', function ($raw) use (&$rawColumns) { | ||
| if (is_null($raw->reward_initial) || $raw->reward_initial == 0) { | ||
| return 'No Reward'; // TODO localise |
Contributor
There was a problem hiding this comment.
TODO that can be resolved
Comment on lines
+109
to
+114
| ['data' => 'name', 'title' => trans_choice('web::seat.name', 1)], | ||
| ['data' => 'last_modified', 'title' => trans_choice('web::seat.last_modified', 1)], | ||
| ['data' => 'state', 'title' => trans('web::seat.state')], | ||
| ['data' => 'progress', 'title' => trans('web::seat.progress')], | ||
| ['data' => 'reward', 'title' => trans('web::seat.reward')], | ||
| ['data' => 'contributors_count', 'title' => trans_choice('web::seat.contributor', 2)], |
Contributor
There was a problem hiding this comment.
Does sorting and searching work on all columns? I don't see it disabled on any column and usually you have to disable a few.
| <h4>About</h4> | ||
|
|
||
| <div class="media"> | ||
| <!-- TODO LATER: consider icons here --> |
Contributor
There was a problem hiding this comment.
I'm just marking all todos
| <div class="row"> | ||
| <div class="col-4"> | ||
| <dl> | ||
| <dt>Career</dt> |
Contributor
There was a problem hiding this comment.
this could probably be localized? There are also other instances in this file
| <div class="modal-dialog modal-lg modal-dialog-scrollable"> | ||
| <div class="modal-content"> | ||
| <div class="modal-header bg-blue"> | ||
| <h4 class="modal-title">Details</h4> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corp Projects! Finally!
Its not perfect. And needs polish on UI for the configurations.. But its a start.
Requires: eveseat/eveapi#445