Repository navigation
fix(ci): ignore the rebased fake secret; unlink localhost URLs in README - #26
Merged
Merged
Conversation
The rebase merge of #20 rewrote 52380ec as 103c04e, so the reviewed fake webhook test secret no longer matched its .gitleaksignore fingerprint and the secret scan failed on main (the README's api ci badge read failing). Both fingerprints are now listed. The README's localhost addresses for a locally running API (health, Swagger UI, ReDoc) were clickable links that fail for any reader; they are now code text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainCI fails, so the api ci badge at the top of the aurora README reads failing.52380ecas103c04e; the reviewed fake webhook test secret's.gitleaksignorefingerprint carries the SHA, so it stopped matching. Both fingerprints are listed now. Local gitleaks over the failing range and over the full history: no leaks.http://localhost:8000/health/live, Swagger UI and ReDoc were clickable links that only work with the API running locally; a reader clicking them gets an error. They are code text now.🤖 Generated with Claude Code