Add Code tab with JavaScript export#13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the export format tabs by introducing a grouped Code tab (currently containing a JavaScript sub-tab) and adds Playwright-based browser smoke tests + CI wiring to catch runtime initialization errors.
Changes:
- Refactor
TabbedTextControlto render tabs from definitions and support grouped subtasks (e.g., Code → JavaScript). - Add Playwright smoke tests with a local
http-serverwebServer config, plus CI steps to install Chromium and run the browser suite. - Add styling for the new subtask UI and update repo hygiene files (
.gitignore, Copilot instructions, etc.).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
js/gui_components/tabbed-text-control.js |
Adds tab definitions and grouped “Code” tab with subtask rendering/activation logic. |
tests/utils/tabbed-text-control-mode.test.js |
Adds unit tests for Code tab/subtask behavior and default selection bootstrapping. |
styles.css |
Adds CSS for conversion subtasks and active “main type” styling. |
tests/browser/page-smoke.spec.js |
Introduces Playwright smoke tests to verify app/generator pages initialize without browser errors. |
playwright.config.js |
Adds Playwright configuration + local web server for browser tests. |
package.json |
Adds Playwright/http-server deps, browser test scripts, and excludes browser tests from Jest runs. |
package-lock.json |
Locks new dependencies for Playwright/http-server. |
.github/workflows/node.js.yml |
Runs Playwright install + browser smoke tests in CI. |
.gitignore |
Ignores Playwright report and test-results output directories. |
docs-src/blog/2026-04-27-export-improvements.md |
Adds a release blog post describing new export features (XML/SQL/JSONL). |
.github/copilot-instructions.md |
Adds project contribution/testing guidance for Copilot-assisted work. |
Comment on lines
+3
to
+29
| title: Export XML, SQL, JSONL | ||
| authors: alan | ||
| tags: [release] | ||
| date: 2026-04-27T19:00 | ||
| --- | ||
|
|
||
| New export features like XML, SQL and JSONL plus improved the speed for exporting large datasets and improved on screen tips. | ||
|
|
||
| <!--truncate--> | ||
|
|
||
| ## Large File Exports | ||
|
|
||
| There is no point being able to upload and amend 1,000,000+ record files if they are painful to export. | ||
|
|
||
| So now they are not. | ||
|
|
||
| You'll see visual progress indicators and the page should not freeze, it should just export data well. | ||
|
|
||
| ## XML, JSONL and SQL | ||
|
|
||
| Export all the L's, now you can export the data as: | ||
|
|
||
| - [XML](/docs/data-formats/xml/xml) | ||
| - [JSONL](/docs/data-formats/jsonl/jsonl) | ||
| - [SQL](/docs/data-formats/sql/sql) | ||
|
|
||
| There should be enough options on the XML and SQL to handle most common simple variants. |
Comment on lines
+11
to
+16
| { | ||
| id: 'code', | ||
| label: 'Code', | ||
| subtasks: [{ id: 'javascript', label: 'JavaScript', type: 'javascript' }], | ||
| }, | ||
| { id: 'gherkin', label: 'Gherkin', type: 'gherkin' }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11