Merge pure API mapper schema reference cleanup#43
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07ddcea78f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ((field.getType() == FieldType.INTEGER | ||
| || field.getType() == FieldType.AUTO_INCREMENT) | ||
| && fieldValue.getSourceType() != BodyFieldValue.SourceType.NUMERIC) { | ||
| errors.add(errorMessage); |
There was a problem hiding this comment.
When callers use the new pure ApiBodyFields.fromMap(...) path with a Java Integer value and declared type enforcement enabled, ThingBodyCommandMapper records the source type as INTEGER, but this validation only accepts NUMERIC for INTEGER/AUTO_INCREMENT fields. A valid payload like Map.of("priority", 1) is therefore rejected with a message saying the field “should be INTEGER but was INTEGER”; include SourceType.INTEGER as valid here.
Useful? React with 👍 / 👎.
Merges the pure API mapper/schema reference DDD cleanup branch into master.\n\nLocal verification before opening: mvn -pl thingifier,challenger -am verify