Add schema YAML editor to CRUD UI#49
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41c72690c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| function applySchemaPreview(preview) { | ||
| state.schemaPreview = preview; | ||
| state.schemaDraft = preview.draft || state.schemaDraft; |
There was a problem hiding this comment.
Keep form handlers attached to the active draft
When a draft preview returns while the user is still editing a schema field, this replaces state.schemaDraft with a new object graph without re-rendering the editor. The existing inputs' input handlers still mutate the old entity/field objects captured by the detail renderers, so any subsequent keystrokes in that same control are omitted from later preview/export requests and can be lost in the downloaded YAML. Either keep the client draft object as the source of truth or re-render/rebind the editor when swapping it.
Useful? React with 👍 / 👎.
Summary
Adds the Issue 46 schema YAML editing story to the standalone CRUD UI.
/schemaSchema Edit page beside the Workspace viewCloses #46
Validation
node --check thingifier-crud-ui\src\main\resources\public\assets\app.jsmvn -pl thingifier-crud-ui -am testmvn -pl thingifier-crud-ui -DskipTests checkstyle:check@project-fqn-checkmvn -pl thingifier-crud-ui -am -DskipTests package