Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Observability score · 64needs work across 3 packages · unchanged against
Note No Fix first (2)
evlog map v1.0.0-beta.2 · how the score works · what each check expects |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: don't merge before
@evlog/cli1.0.0 is on npm (evlog 3.0 GA, 18 Jan 2027). It moves the action's default CLI from 0.8.0 to the 1.0 line. 1.0.0 isn't published yet (latestis 0.11.2,betais 1.0.0-beta.2), so the pin is1.0.0-beta.2and CI runs the action against the real 1.0 contract now. On GA day, change the pin to1.0.0(Renovate will propose it as well), let CI pass, merge and tag. This PR replaces #10 (0.11.2).action.ymlversiondefault and the README inputs table:0.8.0→1.0.0-beta.2.Same fixtures, both CLIs
node src/main.mjslocally, withINPUT_VERSIONset andbaseline: none,gate: true,min-score: 0,summary: true:GITHUB_OUTPUTis identical for every fixture. The job summary differs only in the footer version:The baseline jobs in
test.ymlcover the base-branch scan. That scan uses the same pinned CLI on both sides, so the 1.0 rule set (ruleSetVersion3, up from 1 in 0.x) can't cause a baseline mismatch.What changes in the map JSON between 0.x and 1.0 (diffed on the CLI side in evloghq/evlog#1124):
grade,ignoredandroutes[].eventare new, and nothing the action reads was removed or renamed. #14 makes the job summary pick up any check id the map reports, so 1.x can add checks without an action release.npm test: 88 pass.ELI5
The action runs a specific version of the evlog CLI. This switches it to the upcoming 1.0 version, after checking that the results are the same. It waits as a draft until 1.0.0 is published.