Repository navigation
chore: merge main into v3 - #1129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Risk score: High (3/4)Assessed at b1adb80 from the changed files and the title, by
|
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
Brings
mainintov3before beta.3 (#1017). The only changes onmainthatv3doesn't have yet are #1127 (linear-time checks on thread CPU), #1123 (CLI parser tests, coverage floor, CLI smoke job), #1095 (Evi skill descriptions) and #1128 (forward-slash app labels, npm notices in the skills error). Like #1121, it should land as a merge commit or a fast-forward ofv3to this branch's head, not a squash.Conflicts
.github/workflows/ci.ymlv3's "CLI installs next to evlog 2.x" step intest, andmain's newcli-compatjob (Node 22.0.0 and Windows smoke).cistill needsquality,test,cli-compatandexamples.packages/evlog/test/helpers/timers.tsmerged cleanly: #1126 and #1127 are the same fix.Fix the merge needed
On
v3,evlog initinstallsevlog@betabecause the CLI version is a prerelease (evlogPackageSpecinsrc/lib/init/pm.ts). The five install assertions that #1123 added onmainhard-codednpm install evlog/pnpm add evlog, so they failed on this tree:They now build the expected command with
evlogPackageSpec(VERSION), which is howv3's own tests in the same file already do it (lines 454 and 698).Validation
Run at the head of this branch:
pnpm install --frozen-lockfile,pnpm run dev:prepare: exit 0pnpm run lint,pnpm run typecheck: exit 0pnpm run test: exit 0. evlog 2680/2680, @evlog/cli 962/962, and every other package passes.pnpm --filter @evlog/cli run test:coverage: exit 0. 89.82% statements, 80.04% branches, 92.4% functions, 91.3% lines, all above test(cli): cover init and agents through the parser and gate coverage #1123's floor.main, and the test fix is not user-facing.ELI5
Some fixes landed on the 2.x branch, so this copies them into the 3.0 branch before the next beta. One of the copied tests expected the 2.x install command, so it now expects the 3.0 beta one.