WINMM: Neither ReactOS nor Wine do this check in waveOutOpen, and it …

[fuel-pcbox]

…breaks some demoscene software. Remove

[evmar]

Thanks! I have encountered this too, I should just remove all of the "audio enabled" setting.

[LinusU]

This makes Pocoman.exe (see #43) stop working with the following error:

WARN win32/dll/winmm/src/wave.rs:221 TODO: waveOutOpen callback with window=HANDLE(5)

thread 'main' panicked at cli/src/sdl.rs:140:9:
assertion failed: self.msg_queue.is_none()

Will need to investigate some more, maybe it's related to the logged TODO 🤔

edit: don't think it's related to the todo: #133

[evmar]

I guess the quick thing for you would be to restore this code and just change the flag to be a "disable audio" flag. That is, make the default behavior "audio enabled" and let you run with audio disabled to restore the old behavior.

The assertion that you're hitting here is deep in the message handling code which is kind of gnarly :(
block() is called when we believe all x86 threads are blocked awaiting an event (including possibly a timer) and is supposed to suspend everything until a message is available. It then stashes that message in in self.msg_queue. The assertion failing here means that something called .block() even when there was a message already available, so the caller should have called get_message() in the same file before blocking here. This indicates some bug in how retrowin32 is pumping the message loops.