Java updates#1
Open
pfarner wants to merge 4 commits into
Open
Conversation
pfarner
commented
Jun 15, 2016
- removed redundant generic type specifications
- favored try-with-resources
- applied streams where that seemed appropriate and the other languages used that style
| if (n > 10) | ||
| count++; | ||
| System.out.println(count); | ||
| System.out.println(arr.stream().count()); |
Contributor
There was a problem hiding this comment.
This is not just count, but filtered count. You should count only those values greater than 10. In Python this looks something like this:
sum(1 for i in arr if i > 10)
Author
There was a problem hiding this comment.
Thanks, I missed that. Some unit tests might've caught it.
Owner
|
Thank you! I'm thinking about how to manage language versions. I want to keep Java 7 examples. As soon as I decide this I'll merge this PR. |
Contributor
|
@evmorov I had same thought, some languages, for example JavaScript drastically differs between versions. I think, language mapping based on file extension should be change on path. This: CODE_EXTENSION = {
'coffee' => 'coffeescript',
'rb' => 'ruby',
'java' => 'java',
'py' => 'python',
'php' => 'php'
}.freezecan be changed to this: CODE_EXTENSION = {
'coffee' => 'coffeescript',
'ruby' => 'ruby',
'java/7' => 'java',
'python/3' => 'python',
'php' => 'php'
}.freezeAnd files can be organized in to directories, for example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.