Skip to content

[dependency-track] Dependency track image pull secrets are incompatible with Postgres subchart #183

Description

@ChocPanda

Describe the bug

When configuring image pull secrets when using private docker repositories for both postgres and dependency track the charts require different format image pull secrets and dependency track only reads them from global

The dependency track chart expects image pull secrets in the values:

global:
  imagePullSecrets:
    - name: regcred

The postgres chart expects image pull secrets in the values:

global:
  imagePullSecrets:
    - regcred

Version of Helm and Kubernetes:

Which chart:

Dependency Track

How to reproduce it (as minimally and precisely as possible):

Using values

global:
  imageRegistry: private-repo/repo
  imagePullSecrets:
    - name: regcred

What happened:

 # Source: dependency-track/charts/dependency-track/templates/backend/deployment.yaml
 apiVersion: apps/v1
 kind: Deployment
@@ -187,6 +251,8 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/component: backend
     spec:
+      imagePullSecrets:
+      - name: regcred
 ---
+# Source: dependency-track/charts/postgresql/templates/statefulset.yaml
+apiVersion: apps/v1
+kind: StatefulSet
+    spec:      
+      imagePullSecrets:
+        - name: map[name:regcred]

What you expected to happen:

 # Source: dependency-track/charts/dependency-track/templates/backend/deployment.yaml
 apiVersion: apps/v1
 kind: Deployment
@@ -187,6 +251,8 @@
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/component: backend
     spec:
+      imagePullSecrets:
+      - name: regcred
 ---
+# Source: dependency-track/charts/postgresql/templates/statefulset.yaml
+apiVersion: apps/v1
+kind: StatefulSet
+    spec:      
+      imagePullSecrets:
+      - name: regcred

Anything else we need to know:

Rather than using global values for the image pull secrets could you add .Values.imagePullSecrets value to the dependency track chart and default to the global value if it's null

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions