Skip to content

Allowing user to configure global and per-tier labels - #184

Open
syalioune wants to merge 1 commit into
evryfs:masterfrom
syalioune:feat/extra-label-config
Open

syalioune wants to merge 1 commit into
evryfs:masterfrom
syalioune:feat/extra-label-config

Conversation

@syalioune

Copy link
Copy Markdown

Thanks for maintaining this chart.

The purpose of this PR is to give more flexibility by allowing users to provide common and per tier (frontend/backend) labels.
Existing labels have been integrated into default values file.

@syalioune
syalioune force-pushed the feat/extra-label-config branch from 2624d17 to ebdee3f Compare August 26, 2022 13:00
@syalioune

Copy link
Copy Markdown
Author

Hello @davidkarlsen,
I see that linters are failing since the chart version did not change. I was not sure if version bump was at the discretion of maintainers. Do you expect a commit from me to set chart version to 1.4.2 ?
Thanks

@davidkarlsen

Copy link
Copy Markdown
Collaborator

Yes please so that it can pass CI

@syalioune

Copy link
Copy Markdown
Author

Done 😃

@syalioune

Copy link
Copy Markdown
Author

Hello @davidkarlsen, it's been done !

@syalioune
syalioune force-pushed the feat/extra-label-config branch 2 times, most recently from c628860 to 651b2c4 Compare October 30, 2022 21:41
…r labels

Signed-off-by: Alioune SY <sy_alioune@yahoo.fr>
@syalioune
syalioune force-pushed the feat/extra-label-config branch from 34be077 to 44f0309 Compare November 6, 2022 19:36
@syalioune

Copy link
Copy Markdown
Author

Hello David, any issues preventing merging this branch ?

@hardwarefresser

Copy link
Copy Markdown

I would also like to ask kindly for a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants