Skip to content

🔧 configure additional files to pypi#6

Merged
ewels merged 3 commits intoewels:mainfrom
edircoli:main
Mar 23, 2026
Merged

🔧 configure additional files to pypi#6
ewels merged 3 commits intoewels:mainfrom
edircoli:main

Conversation

@edircoli
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

@edircoli edircoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fix the PyPI release, see #3

@enryH
Copy link
Copy Markdown

enryH commented Mar 23, 2026

Copy link
Copy Markdown
Owner

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Well done for spotting that the pypi distribution is broken, sorry about that 🙈

One specific comment but my claude /review spotted the following:

MANIFEST.in alone may not be enough

MANIFEST.in controls what goes into the sdist (source tarball), but does not guarantee that template files end up in the wheel (the format pip actually installs from in most cases).

To ensure templates are included in installed packages, we also need to configure package data in pyproject.toml. For example, with setuptools:

[build-system]
requires = ["setuptools>=64"]
build-backend = "setuptools.build_meta"

[tool.setuptools.package-data]
nf_docs = ["templates/*"]

Note: pyproject.toml currently has no [build-system] section at all, so this should also be added.

Missing trailing newline

The file is missing a newline at the end. Most editors and linters expect a trailing newline — without one, tools like git diff flag it with \ No newline at end of file.

Comment thread MANIFEST.in Outdated
edircoli and others added 2 commits March 23, 2026 15:58
Copy link
Copy Markdown
Owner

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you!

The CI failure is unrelated, I'll handle that in a separate PR before release. Thanks!

@ewels ewels merged commit 33c7fa7 into ewels:main Mar 23, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants