Skip to content

fix: replace deprecated -p with -ps/-pn/-pa/-pt in CLI tests (closes #315)#316

Merged
woutdenolf merged 3 commits into
ewoks-kit:mainfrom
arinbalyan:fix/issue-315-replace-deprecated-calls
Jun 12, 2026
Merged

fix: replace deprecated -p with -ps/-pn/-pa/-pt in CLI tests (closes #315)#316
woutdenolf merged 3 commits into
ewoks-kit:mainfrom
arinbalyan:fix/issue-315-replace-deprecated-calls

Conversation

@arinbalyan

Copy link
Copy Markdown
Contributor

Description

Fixes #315

Replaces the deprecated -p/--parameter flag across 6 failing test locations in 4 test files. The deprecation warning specifies:

-p/--parameter is deprecated; use -pn for node-specific parameters and -ps for parameters without a node selector.

Additional flags used in the test suite:

  • -ps — parameter without a node selector
  • -pn — node-specific parameter (e.g. task1:b=42)
  • -pa — parameter for --inputs=all mode
  • -pt — taskid-specific parameter (e.g. {taskid}:value=test)

Changes

  • test_cli.py: -p-ps and -pn
  • test_convert_cli.py: -p-pa and -pt
  • test_execute_cli.py: -p-pn and -pa
  • test_show_cli.py: -p-pa

Checklist

  • Each replacement matches the documented deprecation mapping
  • No unrelated changes
  • Commit message references issue

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI tools are great but still miss things. See comments.

Could you tell use what you motivation is for your contribution? Are you using or plan to use Ewoks?

Search for all occurrences of --input-node-id and --inputs and remove/replace. This includes Sphinx docs.

Comment thread src/ewoks/tests/test_convert_cli.py Outdated
Comment thread src/ewoks/tests/test_convert_cli.py Outdated
Comment thread src/ewoks/tests/test_execute_cli.py Outdated
Comment thread src/ewoks/tests/test_show_cli.py

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new CLI arguments requires ewoksutils >=1.10.0rc1. Can you modify pyproject.toml?

In addition the CI still has failing tests. Could you fix those?

Comment thread doc/howtoguides/inspect_workflows.rst Outdated
Comment thread src/ewoks/tests/test_cli.py Outdated
…ering

- Bump ewoksutils minimum version to 1.10.0rc1 (required for new -ps/-pn/-pa/-pt flags)
- Update inspect_workflows.rst docs to list all new parameter flags instead of deprecated -p
- Swap input ordering in test_cli.py per reviewer suggestion

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@woutdenolf woutdenolf merged commit 9ccb71c into ewoks-kit:main Jun 12, 2026
12 checks passed
@arinbalyan

Copy link
Copy Markdown
Contributor Author

Thanks for the help in the entire process !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI tests: replace deprecated calls

2 participants