fix: replace deprecated -p with -ps/-pn/-pa/-pt in CLI tests (closes #315)#316
Merged
woutdenolf merged 3 commits intoJun 12, 2026
Merged
Conversation
woutdenolf
requested changes
Jun 10, 2026
Member
There was a problem hiding this comment.
AI tools are great but still miss things. See comments.
Could you tell use what you motivation is for your contribution? Are you using or plan to use Ewoks?
Search for all occurrences of --input-node-id and --inputs and remove/replace. This includes Sphinx docs.
woutdenolf
requested changes
Jun 12, 2026
woutdenolf
left a comment
Member
There was a problem hiding this comment.
The new CLI arguments requires ewoksutils >=1.10.0rc1. Can you modify pyproject.toml?
In addition the CI still has failing tests. Could you fix those?
woutdenolf
reviewed
Jun 12, 2026
…ering - Bump ewoksutils minimum version to 1.10.0rc1 (required for new -ps/-pn/-pa/-pt flags) - Update inspect_workflows.rst docs to list all new parameter flags instead of deprecated -p - Swap input ordering in test_cli.py per reviewer suggestion
Contributor
Author
|
Thanks for the help in the entire process !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #315
Replaces the deprecated
-p/--parameterflag across 6 failing test locations in 4 test files. The deprecation warning specifies:Additional flags used in the test suite:
-ps— parameter without a node selector-pn— node-specific parameter (e.g.task1:b=42)-pa— parameter for--inputs=allmode-pt— taskid-specific parameter (e.g.{taskid}:value=test)Changes
test_cli.py:-p→-psand-pntest_convert_cli.py:-p→-paand-pttest_execute_cli.py:-p→-pnand-patest_show_cli.py:-p→-paChecklist