fix[pydantic]: Manage pydantic Field.deprecated attribute#458
Merged
maxenceprog merged 2 commits intoJun 25, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
loichuder
reviewed
Jun 5, 2026
Comment on lines
+163
to
+166
| if self.__inputs[name].is_missing(): | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore", DeprecationWarning) | ||
| self.__inputs[name].value = getattr(model, name) |
Member
There was a problem hiding this comment.
I fear this is not clear enough that we want to suppress the DeprecationWarning coming from deprecated fields.
Maybe add a comment? Or make it more explcit in the code:
is_deprecated = self._INPUT_MODEL.model_fields[name].deprecated
not_supplied = self.__inputs[name].is_missing()
if is_deprecated and not_supplied:
....
loichuder
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finally the simplest implementation was to ignore warning only if input is missing.
-> The input is not given by user : No warning
-> The input IS given by user : Deprecation Warning
Note : Default behavior in python is to ignore DeprecationWarning (except in main module). This default behaviour can be overrided (ie: python -W default)