Remove cli#12
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
ewoksdraw exists to generate visual workflow representations for ewoks and ewokssphinx.
The CLI might be useful for development of ewoksdraw itself. But for users not so much, especially because it cannot handle any workflow, only the representations provided by ewokscore (so not .ows files).
I'll let @LudoBroche review since he might have an opinion on removing the CLI. The python function for ewoksdraw as a library is definitely needed.
|
|
||
| canvas.add_element(svg_task) | ||
|
|
||
| canvas.draw(output_path) |
There was a problem hiding this comment.
Note that the SvgCanvas can also generate SVG dict and string representations, not just files. Not sure we should already anticipate this usage.
LudoBroche
left a comment
LudoBroche
left a comment
There was a problem hiding this comment.
I'm fine with removing the CLI at this stage of development.
3 participants
Fix #7
#10 (comment)
The CLI was removed and replaced by a Python function
graph_to_svgthat takes aewokscore.graph.TaskGraphas input.