Skip to content

Draft: canvas: add 'Trigger' action to the link#386

Open
payno wants to merge 10 commits into
mainfrom
add_trigger_option_in_the_canvas
Open

Draft: canvas: add 'Trigger' action to the link#386
payno wants to merge 10 commits into
mainfrom
add_trigger_option_in_the_canvas

Conversation

@payno

@payno payno commented May 19, 2026

Copy link
Copy Markdown
Member

Note to reviewer(s): this PR needs to be updated before merged (once the orangecanvas is released - see associated note).

The rest of the code will not be modified.

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoksorange/gui/canvas/schemeedit.py 55.17% 13 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread src/ewoksorange/gui/canvas/main.py Outdated
Comment thread src/ewoksorange/gui/canvas/main.py Outdated
linkMenu.addAction(self.__linkTriggerAction)

def __linkTrigger(self):
link = self._SchemeEditWidget__contextMenuTarget

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment I don't see how to retrieve the link from the public API.

Comment thread src/ewoksorange/gui/canvas/mainwindow.py Outdated
Comment thread src/ewoksorange/gui/canvas/schemeedit.py
@payno payno requested a review from a team May 21, 2026 06:37
Comment thread src/ewoksorange/gui/canvas/main.py Outdated
Comment thread src/ewoksorange/gui/canvas/mainwindow.py Outdated
Comment thread src/ewoksorange/gui/canvas/schemeedit.py
Comment thread src/ewoksorange/gui/canvas/schemeedit.py Outdated
@payno payno requested a review from woutdenolf May 21, 2026 15:19
@payno payno force-pushed the add_trigger_option_in_the_canvas branch from 2a1a9d3 to d82afaf Compare May 21, 2026 16:12
Comment thread src/ewoksorange/gui/canvas/main.py Outdated
@payno payno force-pushed the add_trigger_option_in_the_canvas branch from 1aa9665 to afc2e12 Compare May 22, 2026 11:31
@payno payno requested a review from woutdenolf May 22, 2026 11:36

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@payno payno changed the title DRAFT: canvas: add 'Trigger' action to the link Draft: canvas: add 'Trigger' action to the link Jun 1, 2026
@payno payno force-pushed the add_trigger_option_in_the_canvas branch from 57a1576 to afc2e12 Compare June 1, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants