Make executors return a Future that allows cancelling and aborting#404
Open
payno wants to merge 15 commits into
Open
Make executors return a Future that allows cancelling and aborting#404payno wants to merge 15 commits into
payno wants to merge 15 commits into
Conversation
…AbortableExecutor.
* now execution returns a future * Executor implements `AbortableExecutor` and `CancellableExecutor` API # Conflicts: # src/ewoksorange/gui/owwidgets/threaded.py
# Conflicts: # src/ewoksorange/gui/concurrency/threaded.py
payno
force-pushed
the
387-owewokswidgetwithtaskstack-provide-api-to-cancel-a-task-2
branch
from
22e261f to
f87b745
Compare
payno
changed the title
…ot available on python 3.9
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
payno
force-pushed
the
387-owewokswidgetwithtaskstack-provide-api-to-cancel-a-task-2
branch
from
4682642 to
95d6a3e
Compare
…utor' and 'CancellableAndAbortableExecutor' to base.
payno
force-pushed
the
387-owewokswidgetwithtaskstack-provide-api-to-cancel-a-task-2
branch
from
5428012 to
5fdfca9
Compare
payno
changed the title
payno
changed the title
woutdenolf
reviewed
Jun 27, 2026
Member
There was a problem hiding this comment.
Lets focus on simplifying the executor logic first like you already started doing but simplify much more: #403 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#403 to be merged first.
Goal
TaskFuture(inherit fromFuture).to handle future (doesn't inherit fromQueue` anymore)