Skip to content

deps : (#245) Remove starlette deprecation warning#246

Merged
maxenceprog merged 2 commits into
mainfrom
245-httpx-is-deprecated-since-starlette-120
Jun 3, 2026
Merged

deps : (#245) Remove starlette deprecation warning#246
maxenceprog merged 2 commits into
mainfrom
245-httpx-is-deprecated-since-starlette-120

Conversation

@maxenceprog

Copy link
Copy Markdown
Contributor

No description provided.

@maxenceprog maxenceprog linked an issue Jun 1, 2026 that may be closed by this pull request
@maxenceprog maxenceprog requested a review from loichuder June 1, 2026 14:24
@maxenceprog

Copy link
Copy Markdown
Contributor Author

looks to be enough ? I'm actually just follwoing the Deprecation warning message but I'm not sure of the impact of this move from httpx to httpx2

@maxenceprog

Copy link
Copy Markdown
Contributor Author

was not so easy apparently... Win test fails

@loichuder

Copy link
Copy Markdown
Member

I am having a look

@loichuder

Copy link
Copy Markdown
Member

Seems to run fine locally. I'll rerun the CI once.

@loichuder loichuder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to be a one-off failure

@maxenceprog maxenceprog merged commit e20c86d into main Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Httpx is deprecated since starlette 1.2.0

2 participants