Skip to content

Add ewoks task exceptions#79

Merged
clarka34 merged 3 commits into
mainfrom
add_ewoks_task_exceptions
Jun 8, 2026
Merged

Add ewoks task exceptions#79
clarka34 merged 3 commits into
mainfrom
add_ewoks_task_exceptions

Conversation

@clarka34

@clarka34 clarka34 commented Jun 4, 2026

Copy link
Copy Markdown
Member

Related to issue: ewoks-kit/ewokscore#71

Adding task exceptions in ewoksutil

@clarka34 clarka34 self-assigned this Jun 4, 2026
@clarka34 clarka34 requested a review from woutdenolf June 4, 2026 15:53
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoksutils/exceptions.py 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@clarka34 clarka34 marked this pull request as draft June 4, 2026 15:57
@woutdenolf woutdenolf self-requested a review June 5, 2026 00:20
@woutdenolf

Copy link
Copy Markdown
Member

Sorry, in ewoks-kit/ewokscore#459 I introduced TaskInputWarning(UserWarning). I merged because the main branch was broken.

Would be good if this was handled in the PR as well.

class TaskError(Exception):
    pass

class TaskExecutionError(EwoksTaskError, RuntimeError):
    pass

class TaskInputError(EwoksTaskError, ValueError):
    pass

class TaskWarning(UserWarning):
    pass

class TaskInputWarning(TaskWarning):
    pass

Thanks!

@clarka34 clarka34 marked this pull request as ready for review June 5, 2026 15:43

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I will deploy a release candidate once this is merged so you can continue in ewokscore.

@clarka34 clarka34 merged commit 0fc17f7 into main Jun 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants