Update react-flow#867
Merged
Merged
Conversation
loichuder
force-pushed
the
reactflow-update
branch
4 times, most recently
from
39bc1a6 to
005b185
Compare
loichuder
force-pushed
the
reactflow-update
branch
from
005b185 to
f67b955
Compare
loichuder
commented
Jun 9, 2026
| fixturesFolder: false, | ||
| screenshotOnRunFailure: false, | ||
| defaultCommandTimeout: 10_000, | ||
| allowCypressEnv: false, |
Member
Author
There was a problem hiding this comment.
Fixing a deprecation warning from Cypress
axelboc
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things to fix:
The way nodes are rendered changed meaning we had to change how to address them in the tests. Previously, they were buttons with a label corresponding to the node label, now they are groups with empty labels. The fix is twofold:
ariaLabelto nodes ourselves usingOnNodesChange: https://reactflow.dev/api-reference/types/on-nodes-changefindNodethat is changed to findgrouprather thanbutton.The
MarkerTypetype did change to use a enum rather than strings. This has effect in both the conversion from Ewoks to ReactFlow edges and in the UI element that controls marker ends. I therefore put some logic in common to avoid duplicating the fix.