You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Uhm, given that nginx is optional I'd not add it as a dependency in the modulefile, eventually i'd just comment it, in order to show thta is needed in case of nginx usage.
The same actually should be done with the apache and mysql modules (the latter being even less useful now that most of the people use PuppetDB).
Sadly I havent' found a more decent way to manage "optional" dependncies in the Modulefile, but I would rather keep them limited (and in some cases incomplete) rather than forcing the installaion of modules that maybe a user doesn't use.
Yeah, it's just super annoying as I'm totally switching over to nginx and geppetto is always complaining since it can't find all the nginx stuff without a module dependency.
Yes, I would prefer such an approach for the moment.
Since I'd already strip off the monitor/firewall dependencies when I publish on the Forge, I might do the same for other lazy dependencies in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.