Fix inverted speaker-separation slider in diarization settings#14
Merged
Conversation
FluidAudio's OfflineDiarizerConfig(clusteringThreshold:) is a cosine similarity (merge when cos_sim >= threshold), not a cosine distance. The setting, slider labels, docstrings, and default were all wired up with the opposite assumption, so picking a "more speakers" value on the slider actually produced more merging and collapsed remote speakers into a single cluster. Rename to diarizationClusteringSimilarity, flip the slider labels, shift the range to 0.40-0.85, raise the default to 0.65 (slightly stricter than FluidAudio's 0.6, matching the original intent), and correct the docstrings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluidAudio's OfflineDiarizerConfig(clusteringThreshold:) is a cosine
similarity (merge when cos_sim >= threshold), not a cosine distance.
The setting, slider labels, docstrings, and default were all wired up
with the opposite assumption, so picking a "more speakers" value on the
slider actually produced more merging and collapsed remote speakers
into a single cluster.
Rename to diarizationClusteringSimilarity, flip the slider labels,
shift the range to 0.40-0.85, raise the default to 0.65 (slightly
stricter than FluidAudio's 0.6, matching the original intent), and
correct the docstrings.