Fix note composer key handling: use NSViewRepresentable instead of onKeyPress#15
Merged
Merged
Conversation
…KeyPress SwiftUI's onKeyPress modifier never fires inside a TextEditor because the underlying NSTextView consumes Return before the SwiftUI event system sees it. The PR #12 approach (onKeyPress on the overlay-decorated TextEditor) also had an overload-resolution ambiguity with the zero-arg vs KeyPress-arg variants that caused build failures on the macos-15 CI runner. Replace TextEditor + onKeyPress with a custom NoteTextEditor NSViewRepresentable that wraps NoteNSTextView. The NSTextView subclass overrides keyDown to route plain Return → submit and Cmd+Return → newline, and grabs first-responder in viewDidMoveToWindow so the panel is immediately ready to type into. https://claude.ai/code/session_01YRGEDv6VQZzf6o6B54UJ5C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftUI's onKeyPress modifier never fires inside a TextEditor because the
underlying NSTextView consumes Return before the SwiftUI event system sees it.
The PR #12 approach (onKeyPress on the overlay-decorated TextEditor) also had
an overload-resolution ambiguity with the zero-arg vs KeyPress-arg variants
that caused build failures on the macos-15 CI runner.
Replace TextEditor + onKeyPress with a custom NoteTextEditor NSViewRepresentable
that wraps NoteNSTextView. The NSTextView subclass overrides keyDown to route
plain Return → submit and Cmd+Return → newline, and grabs first-responder in
viewDidMoveToWindow so the panel is immediately ready to type into.
https://claude.ai/code/session_01YRGEDv6VQZzf6o6B54UJ5C