tui: fix status/lead edits not saving, hide archived by default#5
Merged
Merged
Conversation
startEditStatus and startEditLead never copied the target's base
revision into the model, so a save picked up whatever revision was
left over from the last priority/next-action edit. Against the real
store that stale revision triggers a false concurrency conflict,
silently rejecting the status or lead change instead of applying it.
Also default the dashboard to hiding resolved/archived dossiers (they
were cluttering the view), and turn the lead landing screen ('f') into
a general filter picker: it now includes a pinned row to show/hide
resolved & archived dossiers alongside the existing lead scoping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startEditStatusandstartEditLeadnever copied the target dossier's base revision into the model, so a save picked up a stale revision left over from a previous priority/next-action edit. Against the real store that stale revision triggers a false concurrency conflict, silently rejecting the status/lead change instead of applying it. Both now propagatet.baseRevisioncorrectly.hideResolvedArchived: true) to cut down on noise.ffilter screen is no longer lead-only: it now shows a pinned row to toggle resolved/archived visibility alongside the existing lead-scoping options. Help text updated (f: filter lead→f: filters).dossier_listalready excludes resolved/archived by default (core.Service.Listwith emptystatus), so no change was needed there.Test plan
go build ./...go vet ./.../gofmt -l .cleango test ./...(all packages, including two new regression tests:TestStartEditPropagatesBaseRevision,TestArchivedHiddenByDefault)Generated by Claude Code