Conversation
BNAndras
added
x:module/practice-exercise
|
Oops, I forgot to run vint. I’ll fix that this weekend. |
Sound's like a pre-commit hook could be useful for that. |
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
Approved with possible consideration for the example file.
| if a:minefield[l:newRow][l:newCol] ==# '*' | ||
| let l:count += 1 | ||
| endif |
There was a problem hiding this comment.
The asterisk is not case sensitive in that it does not have an upper or lower case version of itself. So I wonder if the linting is appropriate or if it communicates the wrong thing.
That said, this is an example file, and not all that important. But if this version were given as a student solution, this is the question I would be asking in terms of this syntax here.
There was a problem hiding this comment.
Yeah, I won’t lose any sleep over an example solution not being formatted correctly as long as it passes. The CI check might catch something student-facing in the test suite when we edit the generated test suite for presentation’s sake like multiline lists or something.
2 participants
No description provided.